Return-Path: Delivered-To: apmail-hadoop-core-dev-archive@www.apache.org Received: (qmail 22739 invoked from network); 4 Jun 2008 06:13:09 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 4 Jun 2008 06:13:09 -0000 Received: (qmail 47464 invoked by uid 500); 4 Jun 2008 06:13:11 -0000 Delivered-To: apmail-hadoop-core-dev-archive@hadoop.apache.org Received: (qmail 47432 invoked by uid 500); 4 Jun 2008 06:13:11 -0000 Mailing-List: contact core-dev-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: core-dev@hadoop.apache.org Delivered-To: mailing list core-dev@hadoop.apache.org Received: (qmail 47421 invoked by uid 99); 4 Jun 2008 06:13:11 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 03 Jun 2008 23:13:11 -0700 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.140] (HELO brutus.apache.org) (140.211.11.140) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 04 Jun 2008 06:12:23 +0000 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id 06EF9234C12E for ; Tue, 3 Jun 2008 23:12:45 -0700 (PDT) Message-ID: <1290218557.1212559965027.JavaMail.jira@brutus> Date: Tue, 3 Jun 2008 23:12:45 -0700 (PDT) From: "dhruba borthakur (JIRA)" To: core-dev@hadoop.apache.org Subject: [jira] Commented: (HADOOP-3452) fsck exit code would be better if non-zero when FS corrupt In-Reply-To: <633990245.1211921699869.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/HADOOP-3452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12602181#action_12602181 ] dhruba borthakur commented on HADOOP-3452: ------------------------------------------ +1 code looks good. Is there a reason why we match the string "is CORRUPT" and not just "CORRUPT"? If we are doing this on purpose, then the comment in the DFSck.java should mention that "is CORRUPT" is the precise string that is being used. > fsck exit code would be better if non-zero when FS corrupt > ---------------------------------------------------------- > > Key: HADOOP-3452 > URL: https://issues.apache.org/jira/browse/HADOOP-3452 > Project: Hadoop Core > Issue Type: Improvement > Components: dfs > Reporter: Pete Wyckoff > Priority: Minor > Fix For: 0.18.0 > > Attachments: HADOOP-3452-1.patch, HADOOP-3452-2.patch > > > fsck exit code would be better if behaved like other sys admin tools and exit code indicated healthy/corrupt or other errors. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.