Mailing-List: contact core-dev-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: core-dev@hadoop.apache.org
Message-ID: <1215013497.1214235045339.JavaMail.jira@brutus>
Date: Mon, 23 Jun 2008 08:30:45 -0700 (PDT)
From: "Ari Rabkin (JIRA)" <jira@apache.org>
To: core-dev@hadoop.apache.org
Subject: [jira] Commented: (HADOOP-3616) TextInputFormat taking max of two
 minima as the minimum
In-Reply-To: <211982064.1214007464981.JavaMail.jira@brutus>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HADOOP-3616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12607258#action_12607258 ] 

Ari Rabkin commented on HADOOP-3616:
------------------------------------

This code looks correct -- the programmer's goal was presumably to ensure that the split size was at least mapred.min.split.size -- and that means, you need to take the maximum.

> TextInputFormat taking max of two minima as the minimum
> -------------------------------------------------------
>
>                 Key: HADOOP-3616
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3616
>             Project: Hadoop Core
>          Issue Type: Bug
>    Affects Versions: 0.17.0
>            Reporter: Josh Myer
>            Priority: Minor
>
> When choosing its minimum split size, FileInputFormat is using the larger of the two minimum split values, instead of the smaller.  I can't find any good explanation for why this would be, so it would be helpful to add a comment there (or change to Math.min if that's the intent).
> Line 237:
>     long minSize = Math.max(job.getLong("mapred.min.split.size", 1), minSplitSize);

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.