From core-dev-return-41158-apmail-hadoop-core-dev-archive=hadoop.apache.org@hadoop.apache.org Fri Jun 13 14:43:13 2008 Return-Path: Delivered-To: apmail-hadoop-core-dev-archive@www.apache.org Received: (qmail 36175 invoked from network); 13 Jun 2008 14:43:13 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 13 Jun 2008 14:43:13 -0000 Received: (qmail 36029 invoked by uid 500); 13 Jun 2008 14:43:09 -0000 Delivered-To: apmail-hadoop-core-dev-archive@hadoop.apache.org Received: (qmail 35973 invoked by uid 500); 13 Jun 2008 14:43:09 -0000 Mailing-List: contact core-dev-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: core-dev@hadoop.apache.org Delivered-To: mailing list core-dev@hadoop.apache.org Received: (qmail 35951 invoked by uid 99); 13 Jun 2008 14:43:09 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 13 Jun 2008 07:43:09 -0700 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.140] (HELO brutus.apache.org) (140.211.11.140) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 13 Jun 2008 14:42:28 +0000 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id 75ED6234C139 for ; Fri, 13 Jun 2008 07:42:46 -0700 (PDT) Message-ID: <1928973871.1213368166468.JavaMail.jira@brutus> Date: Fri, 13 Jun 2008 07:42:46 -0700 (PDT) From: "Aaron Greenhouse (JIRA)" To: core-dev@hadoop.apache.org Subject: [jira] Created: (HADOOP-3554) LineRecordReader needs more synchronization MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org LineRecordReader needs more synchronization ------------------------------------------- Key: HADOOP-3554 URL: https://issues.apache.org/jira/browse/HADOOP-3554 Project: Hadoop Core Issue Type: Bug Affects Versions: 0.17.0 Environment: All java platforms Reporter: Aaron Greenhouse LineRecordReader has three index fields start, end, and pos. All of these fields are long, which means that, in general, access to them is not atomic. This can cause problems if the fields are accessed without appropriate synchronization. I propose the following changes to the class: - Make the fields start and end final. This requires some minor changes to the constructor LineRecordReader(Configuration, FileSplit). - Make the method getProgress() synchronized. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.