hadoop-common-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tsz Wo (Nicholas), SZE (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HADOOP-3534) The namenode ignores ioexceptions in close
Date Wed, 11 Jun 2008 18:04:45 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-3534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12604291#action_12604291
] 

Tsz Wo (Nicholas), SZE commented on HADOOP-3534:
------------------------------------------------

In HADOOP-3509, I did the following change
{code}
-        try {
-          dir.close();
-        } catch (IOException ex) {
-          // do nothing
-        }
+        IOUtils.close(LOG, dir);
{code}
Before HADOOP-3509, it formally ignores the IOException.  I think it is good to log the exception,
at least for debug.

How should we handle the exception in close?

> The namenode ignores ioexceptions in close
> ------------------------------------------
>
>                 Key: HADOOP-3534
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3534
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: dfs
>            Reporter: Owen O'Malley
>            Priority: Blocker
>             Fix For: 0.18.0
>
>
> The namenode node in FSNamesystem.close ignores and IOExceptions from closing the namespace.
> {code}
>     IOUtils.close(LOG, dir);
> {code}
> which only logs any exceptions in dir.close() at the debug level.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message