hadoop-common-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HADOOP-3472) MapFile.Reader getClosest() function returns incorrect results when before is true
Date Wed, 04 Jun 2008 04:16:45 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-3472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12602156#action_12602156
] 

Hadoop QA commented on HADOOP-3472:
-----------------------------------

+1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12383150/hadoop_mapfile.2.patch
  against trunk revision 662913.

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 3 new or modified tests.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit
warnings.

    +1 core tests.  The patch passed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2562/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2562/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2562/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2562/console

This message is automatically generated.

> MapFile.Reader getClosest() function returns incorrect results when before is true
> ----------------------------------------------------------------------------------
>
>                 Key: HADOOP-3472
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3472
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: io
>    Affects Versions: 0.16.0, 0.16.1, 0.16.2, 0.16.3, 0.16.4, 0.17.0
>            Reporter: Todd Lipcon
>            Assignee: stack
>             Fix For: 0.17.1, 0.18.0
>
>         Attachments: hadoop_mapfile.2.patch, hadoop_mapfile.patch
>
>
> The MapFile.Reader getClosest() method returns incorrect results due to an error in seekInternal().
The test case in trunk sets the index interval of the test MapFile to 1 which obscures the
issue. There are several other errors in the test case as well that assert incorrect behavior
for getClosest().
> I've got this fixed and tested, and will attach a patch.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message