hadoop-common-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HADOOP-3440) TaskRunner creates a symlink with name 'null' if a file is added to DistributedCache without fragment
Date Fri, 06 Jun 2008 15:55:45 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-3440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12603083#action_12603083
] 

Hadoop QA commented on HADOOP-3440:
-----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12383544/DistributedCache.java.patch
  against trunk revision 663934.

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no tests are needed for this patch.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit
warnings.

    -1 core tests.  The patch failed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2607/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2607/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2607/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2607/console

This message is automatically generated.

> TaskRunner creates a symlink with name 'null' if a file is added to DistributedCache
without fragment
> -----------------------------------------------------------------------------------------------------
>
>                 Key: HADOOP-3440
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3440
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: mapred
>            Reporter: Abhijit Bagri
>            Priority: Minor
>             Fix For: 0.18.0
>
>         Attachments: DistributedCache.java.patch
>
>
> When adding a file to DistributedCache by  either :
> 1. DistributedCache.addCacheArchive(URI, conf) with URI not defining fragment(e.g. not
as new URI("path#fragment") )
> 2. DistributedCache.addCacheFile(URI, conf)  with URI not defining fragment(e.g. not
as new URI("path#fragment") )
> 3. DistributedCache.addArchiveToClassPath(Path, conf) 
> and one sets DistributedCache.createSymlink, TaskRunner creates a link with name 'null'
in the working directory. 
> I think the behavior should be that if fragment is null then no sym link should be created,
adding in localizeCache() of DistributedCache the following
> {code}
>      boolean doSymlink = getSymlink(conf);
> +    if(cache.getFragment() == null) {
> +      doSymlink = false;
> +    }
> FileSystem fs = getFileSystem(cache, conf);
> {code}
>      

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message