hadoop-common-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HADOOP-3427) In ReduceTask::fetchOutputs, wait for result can be improved slightly
Date Wed, 04 Jun 2008 18:48:45 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-3427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12602404#action_12602404
] 

Hadoop QA commented on HADOOP-3427:
-----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12382819/3427.patch
  against trunk revision 663321.

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no tests are needed for this patch.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    -1 findbugs.  The patch appears to introduce 1 new Findbugs warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit
warnings.

    +1 core tests.  The patch passed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2574/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2574/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2574/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2574/console

This message is automatically generated.

> In ReduceTask::fetchOutputs, wait for result can be improved slightly
> ---------------------------------------------------------------------
>
>                 Key: HADOOP-3427
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3427
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: mapred
>            Reporter: Devaraj Das
>            Assignee: Devaraj Das
>             Fix For: 0.18.0
>
>         Attachments: 3427.patch, 3427.patch, 3427.patch
>
>
> The getCopyResult call in ReduceTask::fetchOutputs waits for 2 seconds if the results
list is empty. This can be improved to wait only when sufficient number of fetches (above
a certain threshold) have been scheduled. The threshold should ensure that all the fetcher
threads would be busy enough, and in this case, the call to getCopyResult would return only
when a fetcher thread wakes it up.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message