hadoop-common-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chris Douglas (JIRA)" <j...@apache.org>
Subject [jira] Updated: (HADOOP-3617) Writes from map serialization include redundant checks for accounting space
Date Wed, 25 Jun 2008 19:26:45 GMT

     [ https://issues.apache.org/jira/browse/HADOOP-3617?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Chris Douglas updated HADOOP-3617:
----------------------------------

    Attachment: 3617-3.patch

Fixed one findbugs warning, but the second is spurious. We need to release the lock before
we wait for the spill thread to die, but we don't need to reacquire it as we exit the flush
since there's no contention. In a circumstance where we throw before we release the lock,
it's still unlocked in the finally block.

> Writes from map serialization include redundant checks for accounting space
> ---------------------------------------------------------------------------
>
>                 Key: HADOOP-3617
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3617
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: mapred
>    Affects Versions: 0.17.0
>            Reporter: Chris Douglas
>            Assignee: Chris Douglas
>             Fix For: 0.19.0
>
>         Attachments: 3617-0.patch, 3617-1.patch, 3617-2.patch, 3617-3.patch
>
>
> In BlockingBuffer::write, the collector verifies that there is sufficient space to hold
metadata when it returns to MapOutputBuffer::collect. This check is redundant for serialized
records that make more than one call to write.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message