hadoop-common-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HADOOP-3586) keep combiner backward compatible with earlier versions of hadoop
Date Wed, 18 Jun 2008 06:08:45 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-3586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12605858#action_12605858
] 

Hadoop QA commented on HADOOP-3586:
-----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12384172/3586-0.patch
  against trunk revision 668867.

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no tests are needed for this patch.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    -1 javac.  The applied patch generated 444 javac compiler warnings (more than the trunk's
current 441 warnings).

    -1 findbugs.  The patch appears to introduce 1 new Findbugs warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit
warnings.

    +1 core tests.  The patch passed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2678/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2678/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2678/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2678/console

This message is automatically generated.

> keep combiner backward compatible with earlier versions of hadoop
> -----------------------------------------------------------------
>
>                 Key: HADOOP-3586
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3586
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: mapred
>            Reporter: Olga Natkovich
>            Assignee: Chris Douglas
>            Priority: Blocker
>             Fix For: 0.18.0
>
>         Attachments: 3586-0.patch
>
>
> In hadoop 16 and earlier, the combiner was guaranteed to run once and only once for each
map. In 17 this compatibility was slightly broken: the combiner does not run if a single <K,V>
occupies the entire sort buffer. In 18, this is further changed to where the combiner can
be called multiple times on both map and reduce sides.
> This breaks Pig's current implementation of the combiner and it is not easy to fix in
a short period of time.
> We would like to ask that for a way for an application to ask for a backward compatible
behavior for some period of time until it can adjust to the new behavior.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message