hadoop-common-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Aaron Greenhouse (JIRA)" <j...@apache.org>
Subject [jira] Created: (HADOOP-3554) LineRecordReader needs more synchronization
Date Fri, 13 Jun 2008 14:42:46 GMT
LineRecordReader needs more synchronization
-------------------------------------------

                 Key: HADOOP-3554
                 URL: https://issues.apache.org/jira/browse/HADOOP-3554
             Project: Hadoop Core
          Issue Type: Bug
    Affects Versions: 0.17.0
         Environment: All java platforms
            Reporter: Aaron Greenhouse


LineRecordReader has three index fields start, end, and pos.  All of these fields are long,
which means that, in general, access to them is not atomic.  This can cause problems if the
fields are accessed without appropriate synchronization.  

I propose the following changes to the class:
- Make the fields start and end final.  This requires some minor changes to the constructor
LineRecordReader(Configuration, FileSplit).
- Make the method getProgress() synchronized.


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message