Return-Path: Delivered-To: apmail-hadoop-core-dev-archive@www.apache.org Received: (qmail 89302 invoked from network); 13 May 2008 08:39:25 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 13 May 2008 08:39:25 -0000 Received: (qmail 11315 invoked by uid 500); 13 May 2008 08:39:21 -0000 Delivered-To: apmail-hadoop-core-dev-archive@hadoop.apache.org Received: (qmail 11217 invoked by uid 500); 13 May 2008 08:39:21 -0000 Mailing-List: contact core-dev-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: core-dev@hadoop.apache.org Delivered-To: mailing list core-dev@hadoop.apache.org Received: (qmail 11187 invoked by uid 99); 13 May 2008 08:39:21 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 13 May 2008 01:39:21 -0700 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.140] (HELO brutus.apache.org) (140.211.11.140) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 13 May 2008 08:38:34 +0000 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id B29F4234C119 for ; Tue, 13 May 2008 01:38:55 -0700 (PDT) Message-ID: <552785176.1210667935730.JavaMail.jira@brutus> Date: Tue, 13 May 2008 01:38:55 -0700 (PDT) From: "Devaraj Das (JIRA)" To: core-dev@hadoop.apache.org Subject: [jira] Updated: (HADOOP-3365) SequenceFile.Sorter.MergeQueue.next does an unnecessary copy of the key In-Reply-To: <2104401213.1210230775568.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/HADOOP-3365?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Devaraj Das updated HADOOP-3365: -------------------------------- Hadoop Flags: [Reviewed] Status: Patch Available (was: Open) Pushing the last patch through hudson > SequenceFile.Sorter.MergeQueue.next does an unnecessary copy of the key > ----------------------------------------------------------------------- > > Key: HADOOP-3365 > URL: https://issues.apache.org/jira/browse/HADOOP-3365 > Project: Hadoop Core > Issue Type: Bug > Components: io > Affects Versions: 0.17.0 > Reporter: Arun C Murthy > Assignee: Devaraj Das > Fix For: 0.18.0 > > Attachments: 3365.patch, 3365.patch, 3365.patch > > > SequenceFile.Sorter.MergeQueue.next does an unnecessary copy of the *rawKey*. We should remove that copy, and move code which adjusts the _heap_ from {{next()}} to {{getKey()}}, which should then just return {{ms.getKey()}}, thereby eliminating the extra copy. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.