Mailing-List: contact core-dev-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: core-dev@hadoop.apache.org
Message-ID: <506659857.1210589995915.JavaMail.jira@brutus>
Date: Mon, 12 May 2008 03:59:55 -0700 (PDT)
From: "Hadoop QA (JIRA)" <jira@apache.org>
To: core-dev@hadoop.apache.org
Subject: [jira] Commented: (HADOOP-3203) TaskTracker::localizeJob doesn't
 provide the correct size to LocalDirAllocator
In-Reply-To: <1812972854.1207615285383.JavaMail.jira@brutus>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HADOOP-3203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12596034#action_12596034 ] 

Hadoop QA commented on HADOOP-3203:
-----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12381858/patch-3203.txt
  against trunk revision 655410.

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no tests are needed for this patch.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    +1 core tests.  The patch passed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2451/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2451/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2451/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2451/console

This message is automatically generated.

> TaskTracker::localizeJob doesn't provide the correct size to LocalDirAllocator
> ------------------------------------------------------------------------------
>
>                 Key: HADOOP-3203
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3203
>             Project: Hadoop Core
>          Issue Type: Bug
>    Affects Versions: 0.15.3
>            Reporter: Chris Douglas
>            Assignee: Amareshwari Sriramadasu
>             Fix For: 0.18.0
>
>         Attachments: patch-3203.txt, patch-3203.txt
>
>
> In TaskTracker::localizeJob:
> {code}
>     // Get sizes of JobFile and JarFile
>     // sizes are -1 if they are not present.
>     FileSystem fileSystem = FileSystem.get(fConf);
>     FileStatus status[] = fileSystem.listStatus(new Path(jobFile).getParent());
>     long jarFileSize = -1;
>     long jobFileSize = -1;
>     for(FileStatus stat : status) {
>       if (stat.getPath().toString().contains("job.xml")) {
>         jobFileSize = stat.getLen();
>       } else {
>         jobFileSize = -1;
>       }
>       if (stat.getPath().toString().contains("job.jar")) {
>         jarFileSize = stat.getLen();
>       } else {
>         jarFileSize = -1;
>       }
>     }
> {code}
> One or both of jobFileSize and jarFileSize will be -1.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.