hadoop-common-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HADOOP-3365) SequenceFile.Sorter.MergeQueue.next does an unnecessary copy of the key
Date Fri, 09 May 2008 00:06:55 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-3365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12595433#action_12595433
] 

Hadoop QA commented on HADOOP-3365:
-----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12381671/3365.patch
  against trunk revision 654315.

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no tests are needed for this patch.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit
warnings.

    +1 core tests.  The patch passed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2429/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2429/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2429/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2429/console

This message is automatically generated.

> SequenceFile.Sorter.MergeQueue.next does an unnecessary copy of the key
> -----------------------------------------------------------------------
>
>                 Key: HADOOP-3365
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3365
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: io
>    Affects Versions: 0.17.0
>            Reporter: Arun C Murthy
>            Assignee: Devaraj Das
>             Fix For: 0.18.0
>
>         Attachments: 3365.patch, 3365.patch
>
>
> SequenceFile.Sorter.MergeQueue.next does an unnecessary copy of the *rawKey*. We should
remove that copy, and move code which adjusts the _heap_ from {{next()}} to {{getKey()}},
which should then just return {{ms.getKey()}}, thereby eliminating the extra copy.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message