hadoop-common-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Nigel Daley (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HADOOP-544) Replace the job, tip and task ids with objects.
Date Fri, 02 May 2008 15:40:55 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12593798#action_12593798
] 

Nigel Daley commented on HADOOP-544:
------------------------------------

For all the discussion about deprectatoin, etc, the patch for this issue has broken trunk!
 It no longer compiles on Hudson.  The contrib eclipse plugin relied on an API that you considered
non-Public (JobStatus and perhaps others).  Given we have no well defined public API yet,
I don't think you can assume that classes declared "public" aren't actually public.  At a
minimum, the release notes should indicated that methods were removed and not deprecated.

Build failure:
http://hudson.zones.apache.org/hudson/view/Hadoop/job/Hadoop-trunk/476/console

{quote}
compile:
     [echo] contrib: eclipse-plugin
    [javac] Compiling 45 source files to /zonestorage/hudson/home/hudson/hudson/jobs/Hadoop-trunk/workspace/trunk/build/contrib/eclipse-plugin/classes
    [javac] /zonestorage/hudson/home/hudson/hudson/jobs/Hadoop-trunk/workspace/trunk/src/contrib/eclipse-plugin/src/java/org/apache/hadoop/eclipse/server/HadoopServer.java:119:
cannot find symbol
    [javac] symbol  : method getJobId()
    [javac] location: class org.apache.hadoop.mapred.JobStatus
    [javac]           String jobId = status.getJobId();
    [javac]                                ^
    [javac] Note: Some input files use or override a deprecated API.
    [javac] Note: Recompile with -Xlint:deprecation for details.
    [javac] Note: Some input files use unchecked or unsafe operations.
    [javac] Note: Recompile with -Xlint:unchecked for details.
    [javac] 1 error
{quote}

Can we get this fixed today?



> Replace the job, tip and task ids with objects.
> -----------------------------------------------
>
>                 Key: HADOOP-544
>                 URL: https://issues.apache.org/jira/browse/HADOOP-544
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: mapred
>    Affects Versions: 0.18.0
>            Reporter: Owen O'Malley
>            Assignee: Enis Soztutar
>             Fix For: 0.18.0
>
>         Attachments: id_v1.patch, id_v2.patch, id_v3.patch, id_v4.patch, id_v5.patch,
id_v6.patch, id_v7.patch, id_v8.patch, id_wip1.patch
>
>
> I think that it is silly to have tools parsing the strings that the framework builds
for task ids. I propose:
> class JobId implements Writable {
>    public int getJobId() {...}
> }
> class TaskId implements Writable {
>   public JobId getJobId(); 
>   public boolean isMap() { ... }
>   public int getTaskId() { ... }
> }
> class TaskAttemptId implements Writable {
>   public TaskId getTaskId();
>   public int getAttemptId();
> }
> each of the classes will have a toString() method that generates the current string.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message