hadoop-common-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Owen O'Malley (JIRA)" <j...@apache.org>
Subject [jira] Updated: (HADOOP-3317) add default port for hdfs namenode
Date Thu, 01 May 2008 22:38:55 GMT

     [ https://issues.apache.org/jira/browse/HADOOP-3317?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Owen O'Malley updated HADOOP-3317:
----------------------------------

    Status: Open  (was: Patch Available)

I'm not wild about adding things that are local to the NameNode into FSConstants. (Actually,
the idiom of FSConstants, which just provides constants via inheritance is considered an anti-pattern...)
A static final in NameNode would be better, but it is a nit.

The bigger problem is that you don't have any unit tests. You can't do a system test, because
we don't allow fixed ports in the unit tests, but you can parse the string and get the uri.

The static method NameNode.getUri is passed a NameNode and therefore shouldn't be static.



> add default port for hdfs namenode
> ----------------------------------
>
>                 Key: HADOOP-3317
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3317
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: dfs
>            Reporter: Doug Cutting
>            Assignee: Doug Cutting
>            Priority: Minor
>         Attachments: HADOOP-3317.patch, HADOOP-3317.patch
>
>
> Perhaps we should add a default port number for the HDFS namenode.  This would simplify
URIs.  Instead of hdfs://host.net:9999/foo/bar folks would be able to just use hdfs://host.net/foo/bar
in most cases.  Thoughts?

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message