hadoop-common-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Raghu Angadi (JIRA)" <j...@apache.org>
Subject [jira] Updated: (HADOOP-3382) Memory leak when files are not cleanly closed
Date Wed, 14 May 2008 07:43:55 GMT

     [ https://issues.apache.org/jira/browse/HADOOP-3382?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Raghu Angadi updated HADOOP-3382:
---------------------------------

    Attachment: HADOOP-3382.patch

The patch that is tested manually is attached. As my comment in the patch describes, we do
different things when a block is removed in different context. What is done a block is removed
from NameNode should be in one place. This patch only fixes the observed leak.

I was thinking of writing unit test using abandonFileInProgress() but it is already deprecated.
Since it is fairly simple patch and tested manually, no unit test is required.

> Memory leak when files are not cleanly closed
> ---------------------------------------------
>
>                 Key: HADOOP-3382
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3382
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: dfs
>    Affects Versions: 0.16.0
>            Reporter: Raghu Angadi
>            Assignee: Raghu Angadi
>            Priority: Blocker
>             Fix For: 0.17.0
>
>         Attachments: HADOOP-3382.patch, memleak.txt
>
>
> {{FSNamesystem.internalReleaseCreate()}} in invoked on files that are open for writing
but not cleanly closed. e.g. when client invokes {{abandonFileInProgress()}} or when lease
expires. It deletes the last block if it has a length of zero. The block is deleted from the
file INode but not from {{blocksMap}}. Then leaves a reference to such file until NameNode
is restarted. When this happens  HADOOP-3381 multiplies amount of memory leak.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message