Mailing-List: contact core-dev-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: core-dev@hadoop.apache.org
Message-ID: <282944356.1208219104924.JavaMail.jira@brutus>
Date: Mon, 14 Apr 2008 17:25:04 -0700 (PDT)
From: "Tsz Wo (Nicholas), SZE (JIRA)" <jira@apache.org>
To: core-dev@hadoop.apache.org
Subject: [jira] Updated: (HADOOP-3254) FSNamesystem.gotHeartbeat(...,
 Object[] xferResults, Object[] deleteList) should not use Object[] as
 pass-by-reference parameters
In-Reply-To: <1643499367.1208217424809.JavaMail.jira@brutus>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


     [ https://issues.apache.org/jira/browse/HADOOP-3254?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tsz Wo (Nicholas), SZE updated HADOOP-3254:
-------------------------------------------

    Status: Patch Available  (was: Open)

> FSNamesystem.gotHeartbeat(..., Object[] xferResults, Object[] deleteList) should not use Object[] as pass-by-reference parameters
> ---------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: HADOOP-3254
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3254
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: dfs
>            Reporter: Tsz Wo (Nicholas), SZE
>            Assignee: Tsz Wo (Nicholas), SZE
>         Attachments: 3254_20080414.patch
>
>
> In FSNamesystem.gotHeartbeat(..., Object[] xferResults, Object[] deleteList), xferResults initially equals to Object[] { null, null}.  If there are blocks to be replicated, xferResults[0] and xferResults[1] will be set to a Block[] and DatanodeInfo[][], respectively.  The caller of gotHeartbeat will cast these object to the original classes.  For example, in NameNode.sendHeartbeat(...),
> {code}
>     if (xferResults[0] != null) {
>       assert(deleteList[0] == null);
>       return new BlockCommand((Block[]) xferResults[0], (DatanodeInfo[][]) xferResults[1]);
>     }
> {code}
> The use of deleteList is similar.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.