Mailing-List: contact core-dev-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: core-dev@hadoop.apache.org
Message-ID: <2112316030.1209583435654.JavaMail.jira@brutus>
Date: Wed, 30 Apr 2008 12:23:55 -0700 (PDT)
From: "Chris Douglas (JIRA)" <jira@apache.org>
To: core-dev@hadoop.apache.org
Subject: [jira] Issue Comment Edited: (HADOOP-3031) Remove compiler warnings
 for ant test
In-Reply-To: <167630229.1205749884287.JavaMail.jira@brutus>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HADOOP-3031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12593416#action_12593416 ] 

chris.douglas edited comment on HADOOP-3031 at 4/30/08 12:23 PM:
-----------------------------------------------------------------

+1 for hudson checking for javac warnings as part of the compile-core-test target

We should fix both warnings in this patch. We can strip EmptyInputFormat of even more information, rather than refining it to fit with SequenceFile's constraints, which seems to match the spirit of the test. It's not possible to fix the last warning in TestReduceTask, because WritableComparators are not generic types (i.e. WritableComparator.get(Class<T> c) does not return a WritableComparator<T> that can satisfy the RawComparator<KEY> formal in the ValuesIterator cstr), so we can only suppress the warning.

[ edit \- formatting ]

      was (Author: chris.douglas):
    +1 for hudson checking for javac warnings as part of the compile-core-test target

We should fix both warnings in this patch. We can strip EmptyInputFormat of even more information, rather than refining it to fit with SequenceFile's constraints, which seems to match the spirit of the test. It's not possible to fix the last warning in TestReduceTask, because WritableComparators are not generic types (i.e. WritableComparator.get(Class\<T\> c) does not return a WritableComparator\<T\> that can satisfy the RawComparator\<KEY\> formal in the ValuesIterator cstr), so we can only suppress the warning.
  
> Remove compiler warnings for ant test
> -------------------------------------
>
>                 Key: HADOOP-3031
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3031
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: mapred
>    Affects Versions: 0.17.0
>            Reporter: Amareshwari Sriramadasu
>            Assignee: Amareshwari Sriramadasu
>            Priority: Minor
>             Fix For: 0.18.0
>
>         Attachments: 3031-1.patch, patch-3031-warning1.txt
>
>
> The following warnings need to be removed from ant tests 
> src/test/org/apache/hadoop/mapred/EmptyInputFormat.java:35: warning: [unchecked] unchecked conversion
>     [javac] found   : org.apache.hadoop.mapred.SequenceFileRecordReader
>     [javac] required: org.apache.hadoop.mapred.RecordReader<K,V>
>     [javac]     return new SequenceFileRecordReader(job, (FileSplit) split);
> src/test/org/apache/hadoop/mapred/TestReduceTask.java:91: warning: [unchecked] unchecked call to ValuesIterator(org.apache.hadoop.io.SequenceFile.Sorter.RawKeyValueIterator,org.apache.hadoop.io.RawComparator<KEY>,java.lang.Class<KEY>,java.lang.Class<VALUE>,org.apache.hadoop.conf.Configuration,org.apache.hadoop.util.Progressable) as a member of the raw type org.apache.hadoop.mapred.ReduceTask.ValuesIterator
>     [javac]       new ReduceTask.ValuesIterator(rawItr, WritableComparator.get(Text.class),

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.