Return-Path: Delivered-To: apmail-hadoop-core-dev-archive@www.apache.org Received: (qmail 68815 invoked from network); 15 Apr 2008 22:51:26 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 15 Apr 2008 22:51:26 -0000 Received: (qmail 49733 invoked by uid 500); 15 Apr 2008 22:51:26 -0000 Delivered-To: apmail-hadoop-core-dev-archive@hadoop.apache.org Received: (qmail 49708 invoked by uid 500); 15 Apr 2008 22:51:26 -0000 Mailing-List: contact core-dev-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: core-dev@hadoop.apache.org Delivered-To: mailing list core-dev@hadoop.apache.org Received: (qmail 49699 invoked by uid 99); 15 Apr 2008 22:51:26 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 15 Apr 2008 15:51:26 -0700 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.140] (HELO brutus.apache.org) (140.211.11.140) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 15 Apr 2008 22:50:51 +0000 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id C7EAB234C0D0 for ; Tue, 15 Apr 2008 15:48:21 -0700 (PDT) Message-ID: <1514952660.1208299701817.JavaMail.jira@brutus> Date: Tue, 15 Apr 2008 15:48:21 -0700 (PDT) From: "Hadoop QA (JIRA)" To: core-dev@hadoop.apache.org Subject: [jira] Commented: (HADOOP-3127) rm /user//.Trash/____ only moves it back to .Trash In-Reply-To: <1126510167.1206744984253.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/HADOOP-3127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12589269#action_12589269 ] Hadoop QA commented on HADOOP-3127: ----------------------------------- +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12380175/fixInTrashDeletion.patch against trunk revision 645773. @author +1. The patch does not contain any @author tags. tests included +1. The patch appears to include 3 new or modified tests. javadoc +1. The javadoc tool did not generate any warning messages. javac +1. The applied patch does not generate any new javac compiler warnings. release audit +1. The applied patch does not generate any new release audit warnings. findbugs +1. The patch does not introduce any new Findbugs warnings. core tests +1. The patch passed core unit tests. contrib tests +1. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2242/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2242/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2242/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2242/console This message is automatically generated. > rm /user//.Trash/____ only moves it back to .Trash > ------------------------------------------------------------- > > Key: HADOOP-3127 > URL: https://issues.apache.org/jira/browse/HADOOP-3127 > Project: Hadoop Core > Issue Type: Bug > Components: fs > Affects Versions: 0.16.2, 0.16.3, 0.17.0, 0.18.0 > Reporter: Koji Noguchi > Priority: Minor > Attachments: fixInTrashDeletion.patch > > > In 0.15 or before, any dfs -rm call for files under Trash were deleted. > From 0.16, it just renames it back to Trash. > In Trash.java:moveToTrash() > {noformat} > if (path.toString().startsWith(trash.toString())) > {noformat} > seems like trash.toString() is fully qualified, and path.toString() is not. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.