hadoop-common-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HADOOP-3256) JobHistory file on HDFS should not use the 'job name'
Date Tue, 15 Apr 2008 05:49:04 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-3256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12588917#action_12588917

Hadoop QA commented on HADOOP-3256:

-1 overall.  Here are the results of testing the latest attachment 
against trunk revision 645773.

    @author +1.  The patch does not contain any @author tags.

    tests included -1.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no tests are needed for this patch.

    javadoc +1.  The javadoc tool did not generate any warning messages.

    javac +1.  The applied patch does not generate any new javac compiler warnings.

    release audit +1.  The applied patch does not generate any new release audit warnings.

    findbugs +1.  The patch does not introduce any new Findbugs warnings.

    core tests -1.  The patch failed core unit tests.

    contrib tests +1.  The patch passed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2233/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2233/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2233/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2233/console

This message is automatically generated.

> JobHistory file on HDFS should not use the 'job name'
> -----------------------------------------------------
>                 Key: HADOOP-3256
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3256
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: mapred
>    Affects Versions: 0.17.0
>            Reporter: Arun C Murthy
>            Assignee: Arun C Murthy
>            Priority: Blocker
>             Fix For: 0.17.0
>         Attachments: HADOOP-3256_0_20080414.patch
> HADOOP-2178 introduced the feature of saving jobhistory logs on HDFS.
> Unfortunately the following code:
> {noformat}
>         // setup the history log file for this job
>         String logFileName = jobUniqueString +  
>                              "_" + user+ "_" + jobName;
>         if (logFileName.length() > MAX_FILENAME_SIZE) {
>           logFileName = logFileName.substring(0, MAX_FILENAME_SIZE-1);
>         }
> {noformat}
> is vulnerable to user-provided job names. 
> Specifically I ran into 'URISyntaxException' with jobs whose names include a ":".
> The easy fix is to ensure that we do not use the human-friendly job names and only the
> The long term fix is to ensure that Path handles filenames with _any_ characters.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message