hadoop-common-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "dhruba borthakur (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HADOOP-3270) Constant DatanodeCommand should be stored in static fianl immutable variables.
Date Thu, 17 Apr 2008 22:29:27 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-3270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12590226#action_12590226
] 

dhruba borthakur commented on HADOOP-3270:
------------------------------------------

+1. Code looks good.

> Constant DatanodeCommand should be stored in static fianl immutable variables.
> ------------------------------------------------------------------------------
>
>                 Key: HADOOP-3270
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3270
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: dfs
>            Reporter: Tsz Wo (Nicholas), SZE
>            Assignee: Tsz Wo (Nicholas), SZE
>            Priority: Minor
>         Attachments: 3270_20080417.patch
>
>
> DatanodeCommand like DNA_REGISTER, DNA_BLOCKREPORT and DNA_FINALIZE are constant command.
 New objects should not be created for each time when using these commands.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message