hadoop-common-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HADOOP-2461) Configuration should trim property names and accept decimal, hexadecimal, and octal numbers
Date Fri, 25 Apr 2008 20:19:55 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-2461?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12592489#action_12592489
] 

Hadoop QA commented on HADOOP-2461:
-----------------------------------

+1 overall.  Here are the results of testing the latest attachment 
http://issues.apache.org/jira/secure/attachment/12380961/2461_20080425.patch
against trunk revision 645773.

    @author +1.  The patch does not contain any @author tags.

    tests included +1.  The patch appears to include 5 new or modified tests.

    javadoc +1.  The javadoc tool did not generate any warning messages.

    javac +1.  The applied patch does not generate any new javac compiler warnings.

    release audit +1.  The applied patch does not generate any new release audit warnings.

    findbugs +1.  The patch does not introduce any new Findbugs warnings.

    core tests +1.  The patch passed core unit tests.

    contrib tests +1.  The patch passed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2330/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2330/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2330/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2330/console

This message is automatically generated.

> Configuration should trim property names and accept decimal, hexadecimal, and octal numbers
> -------------------------------------------------------------------------------------------
>
>                 Key: HADOOP-2461
>                 URL: https://issues.apache.org/jira/browse/HADOOP-2461
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: conf
>            Reporter: Tsz Wo (Nicholas), SZE
>            Assignee: Tsz Wo (Nicholas), SZE
>            Priority: Minor
>         Attachments: 2461_20071218.patch, 2461_20080208.patch, 2461_20080425.patch
>
>
> I suggest two improvements in reading configuration:
> - Suppose we have the following property in a conf file.
> {code}
> <property>
> <name>
> testing.property</name>
> <value>something</value>
> </property>
> {code}
> Try to get it by
> {code}
> Configuration conf = new Configuration();
> String value = conf.get("testing.property"); //value == null here
> {code}
> We will get null since there is an eol in 
> {code}
> <name>
> testing.property</name>
> {code}
> I suggest to trim all property names.
> - I also suggest configuration to accept decimal, hexadecimal, and octal numbers (e.g.
011 is 9, 0xA is 10)
> It can be easily done by replacing Integer.parseInt(...) with Integer.decode(...) in
Configuration.getInt(...), similarly, in Configuration.getLong(...).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message