hadoop-common-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Doug Cutting (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HADOOP-3208) WritableDeserializer does not pass the Configuration to deserialized Writables
Date Tue, 08 Apr 2008 19:43:25 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-3208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12586937#action_12586937
] 

Doug Cutting commented on HADOOP-3208:
--------------------------------------

The patch looks good to me.  Can you please add a test case?

Should this be a blocker?  It could break Configurable Writable implementations that depend
on a non-null configuration.

> WritableDeserializer does not pass the Configuration to deserialized Writables
> ------------------------------------------------------------------------------
>
>                 Key: HADOOP-3208
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3208
>             Project: Hadoop Core
>          Issue Type: Bug
>    Affects Versions: 0.17.0
>            Reporter: Enis Soztutar
>            Assignee: Enis Soztutar
>             Fix For: 0.17.0
>
>         Attachments: writableDeserializer_v1.patch
>
>
> {{WritableDeserializer}} does not hold a reference to the Configuration object, so it
does not pass it to deserialized writables, but uses ReflectionUtils.newInstance(writableClass,
null), which results in objects defining Configurable interface to be initialized with null
configuration. 
> Serialization framework have been introduced in 0.17, so this bug affects 0.17. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message