hadoop-common-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Arun C Murthy (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HADOOP-3256) JobHistory file on HDFS should not use the 'job name'
Date Tue, 15 Apr 2008 07:59:04 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-3256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12588965#action_12588965
] 

Arun C Murthy commented on HADOOP-3256:
---------------------------------------

Alternate solution: I guess we can use URL{En|De}code the <jobtrackerHostname, jobId, username,
jobName> quartet to ensure they are legal URIs:
http://java.sun.com/j2se/1.5.0/docs/api/java/net/URLEncoder.html
http://java.sun.com/j2se/1.5.0/docs/api/java/net/URLDecoder.html

Thoughts?

> JobHistory file on HDFS should not use the 'job name'
> -----------------------------------------------------
>
>                 Key: HADOOP-3256
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3256
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: mapred
>    Affects Versions: 0.17.0
>            Reporter: Arun C Murthy
>            Assignee: Arun C Murthy
>            Priority: Blocker
>             Fix For: 0.17.0
>
>         Attachments: HADOOP-3256_0_20080414.patch
>
>
> HADOOP-2178 introduced the feature of saving jobhistory logs on HDFS.
> Unfortunately the following code:
> {noformat}
>         // setup the history log file for this job
>         String logFileName = jobUniqueString +  
>                              "_" + user+ "_" + jobName;
>         if (logFileName.length() > MAX_FILENAME_SIZE) {
>           logFileName = logFileName.substring(0, MAX_FILENAME_SIZE-1);
>         }
> {noformat}
> is vulnerable to user-provided job names. 
> Specifically I ran into 'URISyntaxException' with jobs whose names include a ":".
> The easy fix is to ensure that we do not use the human-friendly job names and only the
jobid.
> The long term fix is to ensure that Path handles filenames with _any_ characters.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message