hadoop-common-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HADOOP-3300) FindBugs warnings in NetworkTopology
Date Wed, 23 Apr 2008 11:09:21 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-3300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12591612#action_12591612
] 

Hadoop QA commented on HADOOP-3300:
-----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
http://issues.apache.org/jira/secure/attachment/12380751/hadoop-3300.patch
against trunk revision 645773.

    @author +1.  The patch does not contain any @author tags.

    tests included -1.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no tests are needed for this patch.

    javadoc +1.  The javadoc tool did not generate any warning messages.

    javac +1.  The applied patch does not generate any new javac compiler warnings.

    release audit +1.  The applied patch does not generate any new release audit warnings.

    findbugs +1.  The patch does not introduce any new Findbugs warnings.

    core tests +1.  The patch passed core unit tests.

    contrib tests +1.  The patch passed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2307/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2307/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2307/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2307/console

This message is automatically generated.

> FindBugs warnings in NetworkTopology
> ------------------------------------
>
>                 Key: HADOOP-3300
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3300
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: dfs
>            Reporter: Tom White
>            Assignee: Tom White
>             Fix For: 0.18.0
>
>         Attachments: hadoop-3300.patch
>
>
> There are a couple of places where explicit locks aren't released correctly:
> org.apache.hadoop.net.NetworkTopology.add(Node) does not release lock on all exception
paths
> and
> org.apache.hadoop.net.NetworkTopology.remove(Node) does not release lock on all exception
paths 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message