hadoop-common-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Amareshwari Sriramadasu (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HADOOP-3256) JobHistory file on HDFS should not use the 'job name'
Date Tue, 15 Apr 2008 09:29:05 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-3256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12588993#action_12588993
] 

Amareshwari Sriramadasu commented on HADOOP-3256:
-------------------------------------------------

some comments
1. The code in jobhistory.jsp should call jobFile.getName.toString() to get the file name,
instead of jobFile.toString()
{code}
+        decodedJobFileName = URLDecoder.decode(jobFile.toString(), "UTF-8");
{code} should be 
{code}
+        decodedJobFileName = URLDecoder.decode(jobFile.getName().toString(), "UTF-8");
{code}

2.  printJob should be passed jobFile, since jobFile is the complete path of the log file
and is used to load the job details in the following jsps. and should not be decoded.
So, the code change 
{code}
       printJob(trackerHostName, trackerStartTime, jobId,
-               jobName, user, jobFile.toString(), out) ; 
+               jobName, user, decodedJobFileName, out) ; 
{code} is not necessary.

3. Otherthan above two comments, indentation issues to do with two spces vs four spaces.


> JobHistory file on HDFS should not use the 'job name'
> -----------------------------------------------------
>
>                 Key: HADOOP-3256
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3256
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: mapred
>    Affects Versions: 0.17.0
>            Reporter: Arun C Murthy
>            Assignee: Arun C Murthy
>            Priority: Blocker
>             Fix For: 0.17.0
>
>         Attachments: HADOOP-3256_0_20080414.patch, HADOOP-3256_1_20080415.patch
>
>
> HADOOP-2178 introduced the feature of saving jobhistory logs on HDFS.
> Unfortunately the following code:
> {noformat}
>         // setup the history log file for this job
>         String logFileName = jobUniqueString +  
>                              "_" + user+ "_" + jobName;
>         if (logFileName.length() > MAX_FILENAME_SIZE) {
>           logFileName = logFileName.substring(0, MAX_FILENAME_SIZE-1);
>         }
> {noformat}
> is vulnerable to user-provided job names. 
> Specifically I ran into 'URISyntaxException' with jobs whose names include a ":".
> The easy fix is to ensure that we do not use the human-friendly job names and only the
jobid.
> The long term fix is to ensure that Path handles filenames with _any_ characters.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message