Return-Path: Delivered-To: apmail-hadoop-core-dev-archive@www.apache.org Received: (qmail 35004 invoked from network); 28 Mar 2008 23:42:42 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 28 Mar 2008 23:42:42 -0000 Received: (qmail 14067 invoked by uid 500); 28 Mar 2008 23:42:40 -0000 Delivered-To: apmail-hadoop-core-dev-archive@hadoop.apache.org Received: (qmail 14058 invoked by uid 500); 28 Mar 2008 23:42:40 -0000 Mailing-List: contact core-dev-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: core-dev@hadoop.apache.org Delivered-To: mailing list core-dev@hadoop.apache.org Received: (qmail 14042 invoked by uid 99); 28 Mar 2008 23:42:40 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 28 Mar 2008 16:42:40 -0700 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.140] (HELO brutus.apache.org) (140.211.11.140) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 28 Mar 2008 23:42:08 +0000 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id 64782234C0A8 for ; Fri, 28 Mar 2008 16:40:26 -0700 (PDT) Message-ID: <935370009.1206747626410.JavaMail.jira@brutus> Date: Fri, 28 Mar 2008 16:40:26 -0700 (PDT) From: "Nigel Daley (JIRA)" To: core-dev@hadoop.apache.org Subject: [jira] Commented: (HADOOP-3128) TestDFSPermission due to not throwing exception. In-Reply-To: <2077573438.1206745344187.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/HADOOP-3128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12583239#action_12583239 ] Nigel Daley commented on HADOOP-3128: ------------------------------------- >From test-patch: [exec] -1 overall. [exec] [exec] @author +1. The patch does not contain any @author tags. [exec] [exec] tests included -1. The patch doesn't appear to include any new or modified tests. [exec] Please justify why no tests are needed for this patch. [exec] [exec] javadoc +1. The javadoc tool did not generate any warning messages. [exec] [exec] javac +1. The applied patch does not generate any new javac compiler warnings. [exec] [exec] findbugs +1. The patch does not introduce any new Findbugs warnings. An existing test caught this problem: TestDFSPermission > TestDFSPermission due to not throwing exception. > ------------------------------------------------ > > Key: HADOOP-3128 > URL: https://issues.apache.org/jira/browse/HADOOP-3128 > Project: Hadoop Core > Issue Type: Bug > Components: dfs > Affects Versions: 0.16.2 > Reporter: Konstantin Shvachko > Assignee: Konstantin Shvachko > Fix For: 0.16.2 > > Attachments: TestDFSPermission.patch > > > This is the consequence of HADOOP-3108. > setPermission nad setOwner should throw RemoteException if it is not FileNotFoundException. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.