Return-Path: Delivered-To: apmail-hadoop-core-dev-archive@www.apache.org Received: (qmail 56565 invoked from network); 6 Mar 2008 18:02:25 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 6 Mar 2008 18:02:25 -0000 Received: (qmail 99237 invoked by uid 500); 6 Mar 2008 18:02:12 -0000 Delivered-To: apmail-hadoop-core-dev-archive@hadoop.apache.org Received: (qmail 99217 invoked by uid 500); 6 Mar 2008 18:02:12 -0000 Mailing-List: contact core-dev-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: core-dev@hadoop.apache.org Delivered-To: mailing list core-dev@hadoop.apache.org Received: (qmail 99181 invoked by uid 99); 6 Mar 2008 18:02:12 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 06 Mar 2008 10:02:12 -0800 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.140] (HELO brutus.apache.org) (140.211.11.140) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 06 Mar 2008 18:01:33 +0000 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id C8352234C0A5 for ; Thu, 6 Mar 2008 10:00:58 -0800 (PST) Message-ID: <558432807.1204826458818.JavaMail.jira@brutus> Date: Thu, 6 Mar 2008 10:00:58 -0800 (PST) From: "Hairong Kuang (JIRA)" To: core-dev@hadoop.apache.org Subject: [jira] Issue Comment Edited: (HADOOP-2870) Datanode.shutdown() and Namenode.stop() should close all rpc connections In-Reply-To: <1889284436.1203629959313.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/HADOOP-2870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12575790#action_12575790 ] hairong edited comment on HADOOP-2870 at 3/6/08 10:00 AM: ---------------------------------------------------------------- The new patch incorporates the following comments: 1. Move Client's reference count to Client; 2. Make TaskTracker and JobClient close connections in close; 3. Move client.stop out of the critical section in stopClient; 4. slowping -> slowPing was (Author: hairong): The new patch incorporates the following comments: 1. Move Client's reference count to Client; 2. Make TaskTracker and JobClient close connections in close; 3. Move stopClient out of the critical section in stopProxy. > Datanode.shutdown() and Namenode.stop() should close all rpc connections > ------------------------------------------------------------------------ > > Key: HADOOP-2870 > URL: https://issues.apache.org/jira/browse/HADOOP-2870 > Project: Hadoop Core > Issue Type: Bug > Components: ipc > Affects Versions: 0.16.0 > Reporter: Hairong Kuang > Assignee: Hairong Kuang > Fix For: 0.17.0 > > Attachments: closeConnection.patch, closeConnection1.patch > > > Currently this two cleanup methods do not close all existing rpc connections. If a mini dfs cluster gets shutdown and then restarted as we do in TestFileCreation, RPCs in second mini cluster reuse the unclosed connections opened in the first run but there is no server running to serve the request. So the client get stuck waiting for the response forever if client side timeout gets removed as suggested by hadoop-2811. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.