Return-Path: 
 <core-dev-return-32497-apmail-hadoop-core-dev-archive=hadoop.apache.org@hadoop.apache.org>
Delivered-To: apmail-hadoop-core-dev-archive@www.apache.org
Received: (qmail 41854 invoked from network); 7 Mar 2008 14:11:08 -0000
Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2)
  by minotaur.apache.org with SMTP; 7 Mar 2008 14:11:08 -0000
Received: (qmail 60570 invoked by uid 500); 7 Mar 2008 14:11:02 -0000
Delivered-To: apmail-hadoop-core-dev-archive@hadoop.apache.org
Received: (qmail 60473 invoked by uid 500); 7 Mar 2008 14:11:02 -0000
Mailing-List: contact core-dev-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:core-dev-help@hadoop.apache.org>
List-Unsubscribe: <mailto:core-dev-unsubscribe@hadoop.apache.org>
List-Post: <mailto:core-dev@hadoop.apache.org>
List-Id: <core-dev.hadoop.apache.org>
Reply-To: core-dev@hadoop.apache.org
Delivered-To: mailing list core-dev@hadoop.apache.org
Received: (qmail 60447 invoked by uid 99); 7 Mar 2008 14:11:02 -0000
Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230)
    by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 07 Mar 2008 06:11:02 -0800
X-ASF-Spam-Status: No, hits=-2000.0 required=10.0
	tests=ALL_TRUSTED
X-Spam-Check-By: apache.org
Received: from [140.211.11.140] (HELO brutus.apache.org) (140.211.11.140)
    by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 07 Mar 2008 14:10:22 +0000
Received: from brutus (localhost [127.0.0.1])
	by brutus.apache.org (Postfix) with ESMTP id 41A32234C0A0
	for <core-dev@hadoop.apache.org>; Fri,  7 Mar 2008 06:09:46 -0800 (PST)
Message-ID: <289141387.1204898986267.JavaMail.jira@brutus>
Date: Fri, 7 Mar 2008 06:09:46 -0800 (PST)
From: "Enis Soztutar (JIRA)" <jira@apache.org>
To: core-dev@hadoop.apache.org
Subject: [jira] Commented: (HADOOP-2834) Iterator for MapFileOutputFormat
In-Reply-To: <25739672.1203021067680.JavaMail.jira@brutus>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-Virus-Checked: Checked by ClamAV on apache.org


    [ https://issues.apache.org/jira/browse/HADOOP-2834?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12576204#action_12576204 ] 

Enis Soztutar commented on HADOOP-2834:
---------------------------------------

We do not offer an Iterator for MapFiles, but use MapFile.Reader#next(). Wouldn't it be better if we (a) add Iterator to MapFile.Reader and apply this patch or (b) change this patch to define MapFileOutputFormat.Reader instead of Iterators, so that reading from MapFile and MapFileOutputFormat is consistent. 

one more minor issue : I think we should change the generics to : 
{code}
private static final class IteratorEntry<K extends WritableComparable, V extends Writable> implements Entry<K, V> {
...
}

private static final class MapFileOutputFormatIterator<K extends WritableComparable, V extends Writable> implements Iterator<Entry<K, V>> {
...
}

public static<K extends WritableComparable, V extends Writable> Iterator<Entry<K, V>>
      getIterator(Path dir, Configuration conf) throws IOException {
...
}
{code}

so that we can use : 
{code}
Iterator<Entry<Text, Text>> x = MapFileOutputFormat.getIterator(path, conf);
{code}


> Iterator for MapFileOutputFormat
> --------------------------------
>
>                 Key: HADOOP-2834
>                 URL: https://issues.apache.org/jira/browse/HADOOP-2834
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: mapred
>    Affects Versions: 0.17.0
>            Reporter: Andrzej Bialecki 
>             Fix For: 0.17.0
>
>         Attachments: map-file-v2.patch, map-file-v3.patch
>
>
> MapFileOutputFormat produces output data that is sorted locally in each part-NNNNN file - however, there is no easy way to iterate over keys from all parts in a globally ascending order.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.