Mailing-List: contact core-dev-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: core-dev@hadoop.apache.org
Message-ID: <27542236.1206792504492.JavaMail.jira@brutus>
Date: Sat, 29 Mar 2008 05:08:24 -0700 (PDT)
From: "Hudson (JIRA)" <jira@apache.org>
To: core-dev@hadoop.apache.org
Subject: [jira] Commented: (HADOOP-2833) JobClient.submitJob(...) should not
 use "Dr Who" as a default username
In-Reply-To: <31209023.1203018669847.JavaMail.jira@brutus>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HADOOP-2833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12583306#action_12583306 ] 

Hudson commented on HADOOP-2833:
--------------------------------

Integrated in Hadoop-trunk #445 (See [http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/445/])

> JobClient.submitJob(...) should not use "Dr Who" as a default username
> ----------------------------------------------------------------------
>
>                 Key: HADOOP-2833
>                 URL: https://issues.apache.org/jira/browse/HADOOP-2833
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: mapred
>            Reporter: Tsz Wo (Nicholas), SZE
>            Assignee: Tsz Wo (Nicholas), SZE
>             Fix For: 0.16.2
>
>         Attachments: 2833_20080225.patch, 2833_20080227.patch, 2833_20080227b.patch, 2833_20080228.patch
>
>
> In JobClient line 530, we have
> {code}
> String user = System.getProperty("user.name");
> job.setUser(user != null ? user : "Dr Who");
> {code}
> Since a ugi is already obtained in the earlier codes, we should get the username from ugi, not System.getProperty("user.name").  Also, Exception should be thrown if the username is null, instead of using a default.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.