Return-Path: Delivered-To: apmail-hadoop-core-dev-archive@www.apache.org Received: (qmail 83279 invoked from network); 17 Mar 2008 07:03:11 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 17 Mar 2008 07:03:11 -0000 Received: (qmail 17072 invoked by uid 500); 17 Mar 2008 07:03:08 -0000 Delivered-To: apmail-hadoop-core-dev-archive@hadoop.apache.org Received: (qmail 16850 invoked by uid 500); 17 Mar 2008 07:03:07 -0000 Mailing-List: contact core-dev-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: core-dev@hadoop.apache.org Delivered-To: mailing list core-dev@hadoop.apache.org Received: (qmail 16841 invoked by uid 99); 17 Mar 2008 07:03:07 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 17 Mar 2008 00:03:07 -0700 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.140] (HELO brutus.apache.org) (140.211.11.140) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 17 Mar 2008 07:02:26 +0000 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id 3889E234C09D for ; Mon, 17 Mar 2008 00:01:24 -0700 (PDT) Message-ID: <1641312081.1205737284230.JavaMail.jira@brutus> Date: Mon, 17 Mar 2008 00:01:24 -0700 (PDT) From: "Devaraj Das (JIRA)" To: core-dev@hadoop.apache.org Subject: [jira] Assigned: (HADOOP-3030) InMemoryFileSystem.reserveSpaceWithChecksum does not look at failures while reserving space for the file in question In-Reply-To: <470860533.1205736444210.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/HADOOP-3030?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Devaraj Das reassigned HADOOP-3030: ----------------------------------- Assignee: Devaraj Das > InMemoryFileSystem.reserveSpaceWithChecksum does not look at failures while reserving space for the file in question > -------------------------------------------------------------------------------------------------------------------- > > Key: HADOOP-3030 > URL: https://issues.apache.org/jira/browse/HADOOP-3030 > Project: Hadoop Core > Issue Type: Bug > Components: fs > Reporter: Devaraj Das > Assignee: Devaraj Das > Fix For: 0.17.0 > > Attachments: hadoop-3030.patch > > > The return statement code in InMemoryFileSystem.reserveSpaceWithCheckSum looks like > {noformat} > return (mfs.reserveSpace(f, size) && mfs.reserveSpace(getChecksumFile(f), checksumSize)); > {noformat} > This should be broken up to check for successful reserveSpace for each of the components. In some cases, we might reserve space for the first component and fail while doing the same for the second (checksum file). This will lead to wastage of space since we don't un-reserve the space we got for the first component. This usually won't happen due to the policy associated with creating a file in the InMemoryFileSystem (since the checksum component is usually very small) but still it should be fixed. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.