Return-Path: Delivered-To: apmail-hadoop-core-dev-archive@www.apache.org Received: (qmail 41234 invoked from network); 21 Mar 2008 04:35:22 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 21 Mar 2008 04:35:22 -0000 Received: (qmail 2132 invoked by uid 500); 21 Mar 2008 04:35:19 -0000 Delivered-To: apmail-hadoop-core-dev-archive@hadoop.apache.org Received: (qmail 2017 invoked by uid 500); 21 Mar 2008 04:35:19 -0000 Mailing-List: contact core-dev-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: core-dev@hadoop.apache.org Delivered-To: mailing list core-dev@hadoop.apache.org Received: (qmail 2007 invoked by uid 99); 21 Mar 2008 04:35:18 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 20 Mar 2008 21:35:18 -0700 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.140] (HELO brutus.apache.org) (140.211.11.140) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 21 Mar 2008 04:34:37 +0000 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id 4846B234C0A9 for ; Thu, 20 Mar 2008 21:33:24 -0700 (PDT) Message-ID: <1420850276.1206074004295.JavaMail.jira@brutus> Date: Thu, 20 Mar 2008 21:33:24 -0700 (PDT) From: "Hadoop QA (JIRA)" To: core-dev@hadoop.apache.org Subject: [jira] Commented: (HADOOP-3007) DataNode pipelining : failure on mirror results in failure on upstream datanode In-Reply-To: <1633241344.1205357086439.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/HADOOP-3007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12580998#action_12580998 ] Hadoop QA commented on HADOOP-3007: ----------------------------------- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12378264/HADOOP-3007.patch against trunk revision 619744. @author +1. The patch does not contain any @author tags. tests included -1. The patch doesn't appear to include any new or modified tests. Please justify why no tests are needed for this patch. javadoc +1. The javadoc tool did not generate any warning messages. javac +1. The applied patch does not generate any new javac compiler warnings. release audit +1. The applied patch does not generate any new release audit warnings. findbugs +1. The patch does not introduce any new Findbugs warnings. core tests +1. The patch passed core unit tests. contrib tests +1. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2017/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2017/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2017/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2017/console This message is automatically generated. > DataNode pipelining : failure on mirror results in failure on upstream datanode > ------------------------------------------------------------------------------- > > Key: HADOOP-3007 > URL: https://issues.apache.org/jira/browse/HADOOP-3007 > Project: Hadoop Core > Issue Type: Bug > Components: dfs > Affects Versions: 0.16.0 > Reporter: Raghu Angadi > Assignee: Raghu Angadi > Priority: Blocker > Fix For: 0.16.2 > > Attachments: HADOOP-3007.patch, HADOOP-3007.patch > > > When datanode is transfering data to other datanodes (as opposed to a client write()), DN currently receiving the data is supposed to continued to receive even if the downstream (mirror) datanode fails. > I think there are two minor bugs in receiveBlock() : > # mirrorSock masks this.mirrorSock, which could be set to null by other members like receiveChunk() to indicate failure. > # when this.mirrorSock is non null, failure to write to it at in receiveBlock() should be handled same way as in receiveChunk(). > I am not sure if this should block 0.16.1, but should surely block 0.16.2. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.