Mailing-List: contact core-dev-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: core-dev@hadoop.apache.org
Message-ID: <1054635542.1205342687364.JavaMail.jira@brutus>
Date: Wed, 12 Mar 2008 10:24:47 -0700 (PDT)
From: "Tsz Wo (Nicholas), SZE (JIRA)" <jira@apache.org>
To: core-dev@hadoop.apache.org
Subject: [jira] Commented: (HADOOP-3003) FileSystem cache key should be
 updated after a FileSystem object is created
In-Reply-To: <1200851292.1205286526543.JavaMail.jira@brutus>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HADOOP-3003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12577940#action_12577940 ] 

Tsz Wo (Nicholas), SZE commented on HADOOP-3003:
------------------------------------------------

> ... updated user information. Is that right?
That's is true.

In HADOOP-2915, there is a discussion about using WeakReference in the cache, so that un-referenced fs could be closed automatically.  In that case, the cache values have to be FsRef (extending WeakReference).  You are right that we don't need FsRef currently.  Do you want me to remove it or keep it for future use?
See https://issues.apache.org/jira/browse/HADOOP-2915?focusedCommentId=12575175#action_12575175

> FileSystem cache key should be updated after a FileSystem object is created
> ---------------------------------------------------------------------------
>
>                 Key: HADOOP-3003
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3003
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: fs
>            Reporter: Tsz Wo (Nicholas), SZE
>            Assignee: Tsz Wo (Nicholas), SZE
>             Fix For: 0.16.2
>
>         Attachments: 3003_20080311.patch
>
>
> In FileSystem.get(uri, conf), it first creates a cache key from the uri and the conf and then lookups the corresponding FileSystem object in the cache.  If the object is not found, it initializes a FileSystem object and put it to the cache with the key.  However, during FileSystem creation, the conf might be modified.  In such case, the key should be updated before putting it to the cache.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.