hadoop-common-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Koji Noguchi (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HADOOP-2880) libhdfs: O_WRONLY/O_RDONLY different when including fcntl.h
Date Thu, 27 Mar 2008 08:23:24 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-2880?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12582540#action_12582540
] 

Koji Noguchi commented on HADOOP-2880:
--------------------------------------

Christian pointed out to me that,

bq. I ran into the problem in the past, but now hdfs.h (since hadoop-0.9.x, believe) already
includes fcntl.h before defining the macros, i.e. on linux it should be 0 for O_RDONLY and
1 for O_WRONLY.

This makes complete sense.  I don't know what I was hitting, but my comments are all incorrect.
I'll close this Jira as invalid once I confirm.

> libhdfs: O_WRONLY/O_RDONLY different when including fcntl.h
> -----------------------------------------------------------
>
>                 Key: HADOOP-2880
>                 URL: https://issues.apache.org/jira/browse/HADOOP-2880
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: libhdfs
>         Environment: linux
>            Reporter: Koji Noguchi
>            Priority: Blocker
>             Fix For: 0.18.0
>
>
> In hdfs.h, 
> #ifndef O_RDONLY
> #define O_RDONLY 1
> #endif
> #ifndef O_WRONLY
> #define O_WRONLY 2
> #endif
> but on linux, 
> $ grep "define O_RDONLY" /usr/include/*/*
> /usr/include/asm-i386/fcntl.h:#define O_RDONLY       00
> /usr/include/asm-x86_64/fcntl.h:#define O_RDONLY             00
> /usr/include/bits/fcntl.h:#define O_RDONLY           00
> $ grep "define O_WRONLY" /usr/include/*/*
> /usr/include/asm-i386/fcntl.h:#define O_WRONLY       01
> /usr/include/asm-x86_64/fcntl.h:#define O_WRONLY             01
> /usr/include/bits/fcntl.h:#define O_WRONLY           01
> It took me a while to debug when hdfsOpenFile was trying to 'write' when I meant 'read'.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message