hadoop-common-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HADOOP-3008) SocketIOWithTimeout does not handle thread interruption
Date Sat, 15 Mar 2008 05:07:24 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-3008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12579007#action_12579007
] 

Hadoop QA commented on HADOOP-3008:
-----------------------------------

+1 overall.  Here are the results of testing the latest attachment 
http://issues.apache.org/jira/secure/attachment/12377840/HADOOP-3008.patch
against trunk revision 619744.

    @author +1.  The patch does not contain any @author tags.

    tests included +1.  The patch appears to include 3 new or modified tests.

    javadoc +1.  The javadoc tool did not generate any warning messages.

    javac +1.  The applied patch does not generate any new javac compiler warnings.

    release audit +1.  The applied patch does not generate any new release audit warnings.

    findbugs +1.  The patch does not introduce any new Findbugs warnings.

    core tests +1.  The patch passed core unit tests.

    contrib tests +1.  The patch passed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/1967/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/1967/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/1967/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/1967/console

This message is automatically generated.

> SocketIOWithTimeout does not handle thread interruption
> -------------------------------------------------------
>
>                 Key: HADOOP-3008
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3008
>             Project: Hadoop Core
>          Issue Type: Bug
>    Affects Versions: 0.17.0
>            Reporter: Raghu Angadi
>            Assignee: Raghu Angadi
>             Fix For: 0.17.0
>
>         Attachments: HADOOP-3008.patch, HADOOP-3008.patch, HADOOP-3008.patch, HADOOP-3008.patch
>
>
> If a thread is waiting in {{SocketIOWithTimeout.select()}} for IO and is interrupted
by another thread, select() returns zero. But current implementation does not check if the
thread is interrupted and goes back to waiting. But it should check if the thread is interrupted.
> In this case, I am thinking of throwing {{InterruptedIOException}} http://java.sun.com/j2se/1.5.0/docs/api/java/io/InterruptedIOException.html.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message