hadoop-common-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Owen O'Malley (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HADOOP-2870) Datanode.shutdown() and Namenode.stop() should close all rpc connections
Date Wed, 05 Mar 2008 18:51:44 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-2870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12575455#action_12575455
] 

Owen O'Malley commented on HADOOP-2870:
---------------------------------------

I think a ClientInfo that wraps Client adding a reference count seems like overkill. Why not
just add the reference count to Client itself?

I wonder if the reference counting  is better done by WeakReference? In particular, you should
also have the JobTracker and TaskTracker free up their ipc clients too.

In the test code 'slowping' should be 'slowPing'.

A big thanks for removing the unit test code from the main source code :)

> Datanode.shutdown() and Namenode.stop() should close all rpc connections
> ------------------------------------------------------------------------
>
>                 Key: HADOOP-2870
>                 URL: https://issues.apache.org/jira/browse/HADOOP-2870
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: ipc
>    Affects Versions: 0.16.0
>            Reporter: Hairong Kuang
>            Assignee: Hairong Kuang
>             Fix For: 0.17.0
>
>         Attachments: closeConnection.patch
>
>
> Currently this two cleanup methods do not close all existing rpc connections. If a mini
dfs cluster gets shutdown and then restarted as we do in TestFileCreation, RPCs in second
mini cluster reuse the unclosed connections opened in the first run but there is no server
running to serve the request. So the client get stuck waiting for the response forever if
client side timeout gets removed as suggested by hadoop-2811.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message