hadoop-common-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HADOOP-3030) InMemoryFileSystem.reserveSpaceWithChecksum does not look at failures while reserving space for the file in question
Date Thu, 20 Mar 2008 13:15:26 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-3030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12580745#action_12580745
] 

Hudson commented on HADOOP-3030:
--------------------------------

Integrated in Hadoop-trunk #434 (See [http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/434/])

> InMemoryFileSystem.reserveSpaceWithChecksum does not look at failures while reserving
space for the file in question
> --------------------------------------------------------------------------------------------------------------------
>
>                 Key: HADOOP-3030
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3030
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: fs
>            Reporter: Devaraj Das
>            Assignee: Devaraj Das
>             Fix For: 0.17.0
>
>         Attachments: 3030.patch, hadoop-3030.patch
>
>
> The return statement code in InMemoryFileSystem.reserveSpaceWithCheckSum looks like
> {noformat}
>   return (mfs.reserveSpace(f, size) && mfs.reserveSpace(getChecksumFile(f), checksumSize));
> {noformat}
> This should be broken up to check for successful reserveSpace for each of the components.
In some cases, we might reserve space for the first component and fail while doing the same
for the second (checksum file). This will lead to wastage of space since we don't un-reserve
the space we got for the first component. This usually won't happen due to the policy associated
with creating a file in the InMemoryFileSystem (since the checksum component is usually very
small) but still it should be fixed.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message