hadoop-common-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chris Douglas (JIRA)" <j...@apache.org>
Subject [jira] Issue Comment Edited: (HADOOP-3048) Stringifier
Date Sat, 29 Mar 2008 01:02:24 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-3048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12583257#action_12583257
] 

chris.douglas edited comment on HADOOP-3048 at 3/28/08 6:00 PM:
----------------------------------------------------------------

* I'm uncomfortable with GenericsUtil. It can't be denied that Java generics have some fiercely
annoying properties, but factoring this out is probably the wrong solution. Where GenericsUtil::getClass(T)
is called, Class::asSubclass(Class) should be preferred. Similarly, GenericsUtil::toArray
is called from a function that's destringifying and deserializing objects. It's not statically-checkable
code, the casts are wholly justified, and the warning should be suppressed. Contexts where
toArray might be useful should typically prefer the equally typesafe implementation in ArrayList
(this case included).
* Since {{separator}} is a constant, it should be in all caps

Other than that, this looks great.

bq. I think there is no need to develop a framework such as the Serialization until a need
for another Stringifier emerges.

Agreed.

      was (Author: chris.douglas):
    * I'm uncomfortable with GenericsUtil. It can't be denied that Java generics have some
fiercely annoying properties, but factoring this out is probably the wrong solution. Where
GenericsUtil::getClass(T) is called, Class::asSubclass(Class) should be preferred. Similarly,
GenericsUtil::toArray is called from a function that's destringifying and deserializing objects.
It's not statically-checkable code, the casts are wholly justified, and the warning should
be suppressed. Contexts where toArray might be useful should typically prefer the equally
typesafe implementation in ArrayList (this case included).
* Since {{separator}} is a constant, it should be in all caps

Other than that, this looks great.
  
> Stringifier
> -----------
>
>                 Key: HADOOP-3048
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3048
>             Project: Hadoop Core
>          Issue Type: New Feature
>    Affects Versions: 0.17.0
>            Reporter: Enis Soztutar
>            Assignee: Enis Soztutar
>            Priority: Blocker
>             Fix For: 0.17.0
>
>         Attachments: stringifier_v1.patch, stringifier_v2.patch, stringifier_v3.patch,
stringifier_v4.patch, stringifier_v5.patch
>
>
> Storing arbitrary objects in the configuration has been discussed before in HADOOP-449
and HADOOP-1873. Although enabling such functionality has the risk of encouraging people to
put big binary objects in the configuration, for some use cases passing objects to tasks is
absolutely necessary. 
> This issue will track the implementation of a Stringifier interface which stringifies
and destringifies objects. Using this implementation, developers can store objects in the
configuration and restore them later. 
> Any thoughts ?

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message