hadoop-common-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chris Douglas (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HADOOP-2906) output format classes that can write to different files depending on keys and/or config variable
Date Tue, 04 Mar 2008 21:37:44 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-2906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12575154#action_12575154
] 

Chris Douglas commented on HADOOP-2906:
---------------------------------------

A couple suggestions:
* If "num.of.trailing.legs.to.use" exceeds the number of segments in the input file path string,
then this will throw an IllegalArgumentException from Path. A more helpful message should
probably accompany this condition.
* It might be worth calling out in the javadocs that {{generateActualKey}} and {{generateActualValue}}
should be aware of side-effects, since {{write}} typically doesn't modify its args and the
framework will reuse them. The code is clear enough that users can educate themselves, but
this is deserving of a footnote.

Otherwise, +1

> output format classes that can write to different files depending on  keys and/or config
variable
> -------------------------------------------------------------------------------------------------
>
>                 Key: HADOOP-2906
>                 URL: https://issues.apache.org/jira/browse/HADOOP-2906
>             Project: Hadoop Core
>          Issue Type: New Feature
>          Components: mapred
>            Reporter: Runping Qi
>            Assignee: Runping Qi
>         Attachments: patch.2096.5.txt
>
>
> I've a few apps that require to write out data into different files/directories depending
on keys and/or configuration variables.
> I've implemented such classes for those apps. I noticed that many other users have similar
need from time to time.
> So I think it may be a good idea to contribute to Hadoop mapred.lib package so that other
users can benefit from it.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message