hadoop-common-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mahadev konar (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HADOOP-2826) FileSplit.getFile(), LineRecordReader. readLine() need to be removed
Date Mon, 31 Mar 2008 18:46:24 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-2826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12583793#action_12583793
] 

Mahadev konar commented on HADOOP-2826:
---------------------------------------

instead of public static byte [] readLine(LineReader lineReader) 

why not pass a text object ? 

public static readLine(LineReader lineReader, Text t) 

  read into t 
}

the call would be something like .... 
t.clear() 
call readline(reader, t)

that would save creating object Text for each readline invocation? 



> FileSplit.getFile(), LineRecordReader. readLine() need to be removed
> --------------------------------------------------------------------
>
>                 Key: HADOOP-2826
>                 URL: https://issues.apache.org/jira/browse/HADOOP-2826
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: mapred
>            Reporter: Amareshwari Sriramadasu
>            Assignee: Amareshwari Sriramadasu
>             Fix For: 0.17.0
>
>         Attachments: patch-2826.txt
>
>
> The methods FileSplit.getFile(), LineRecordReader. readLine() need to be removed as they
are deprecated.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message