Return-Path: Delivered-To: apmail-hadoop-core-dev-archive@www.apache.org Received: (qmail 92659 invoked from network); 21 Feb 2008 22:06:00 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 21 Feb 2008 22:06:00 -0000 Received: (qmail 49005 invoked by uid 500); 21 Feb 2008 22:05:54 -0000 Delivered-To: apmail-hadoop-core-dev-archive@hadoop.apache.org Received: (qmail 48989 invoked by uid 500); 21 Feb 2008 22:05:54 -0000 Mailing-List: contact core-dev-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: core-dev@hadoop.apache.org Delivered-To: mailing list core-dev@hadoop.apache.org Received: (qmail 48980 invoked by uid 99); 21 Feb 2008 22:05:54 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 21 Feb 2008 14:05:54 -0800 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.140] (HELO brutus.apache.org) (140.211.11.140) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 21 Feb 2008 22:05:16 +0000 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id 3FB8F234C043 for ; Thu, 21 Feb 2008 14:05:19 -0800 (PST) Message-ID: <1240924412.1203631519259.JavaMail.jira@brutus> Date: Thu, 21 Feb 2008 14:05:19 -0800 (PST) From: "Hadoop QA (JIRA)" To: core-dev@hadoop.apache.org Subject: [jira] Commented: (HADOOP-2869) Deprecate and remove SequenceFile.setCompressionType In-Reply-To: <2111417829.1203626600130.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/HADOOP-2869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12571201#action_12571201 ] Hadoop QA commented on HADOOP-2869: ----------------------------------- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12376166/HADOOP-2869_0_20080221.patch against trunk revision 619744. @author +1. The patch does not contain any @author tags. tests included -1. The patch doesn't appear to include any new or modified tests. Please justify why no tests are needed for this patch. javadoc +1. The javadoc tool did not generate any warning messages. javac -1. The applied patch generated 620 javac compiler warnings (more than the trunk's current 619 warnings). release audit +1. The applied patch does not generate any new release audit warnings. findbugs +1. The patch does not introduce any new Findbugs warnings. core tests +1. The patch passed core unit tests. contrib tests +1. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/1830/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/1830/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/1830/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/1830/console This message is automatically generated. > Deprecate and remove SequenceFile.setCompressionType > ---------------------------------------------------- > > Key: HADOOP-2869 > URL: https://issues.apache.org/jira/browse/HADOOP-2869 > Project: Hadoop Core > Issue Type: Bug > Affects Versions: 0.15.0 > Reporter: Arun C Murthy > Assignee: Arun C Murthy > Fix For: 0.16.1 > > Attachments: HADOOP-2869_0_20080221.patch > > > The right context for compression is either: > a) SequenceFile.createWriter > b) SequenceFileOutputFormat.setCompressionType > c) JobConf.setMapOutputCompressionType > Hence, we need to remove (deprecate for now) SequenceFIle.setCompressionType. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.