hadoop-common-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tsz Wo (Nicholas), SZE (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HADOOP-2767) org.apache.hadoop.net.NetworkTopology.InnerNode#getLeaf does not return the last node on a rack when used with an excluded node
Date Tue, 05 Feb 2008 23:05:09 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-2767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12565939#action_12565939
] 

Tsz Wo (Nicholas), SZE commented on HADOOP-2767:
------------------------------------------------

excludedLeaf3.patch: +1
codes look good, I suggest the following change:
{code}
      ...
      int numOfExcludedLeaves = 1;
      boolean isLeaf = !(excludedNode instanceof InnerNode);
      if (!isLeaf) {
        numOfExcludedLeaves = ((InnerNode)excludedNode).getNumOfLeaves();
      }
{code}

> org.apache.hadoop.net.NetworkTopology.InnerNode#getLeaf does not return the last node
on a rack when used with an excluded node
> -------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: HADOOP-2767
>                 URL: https://issues.apache.org/jira/browse/HADOOP-2767
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: dfs
>            Reporter: Mark Butler
>            Assignee: Hairong Kuang
>            Priority: Minor
>         Attachments: excludedLeaf.patch, excludedLeaf2.patch, excludedLeaf3.patch, NetworkTopologyTest.java
>
>
> I have written some test code that shows NetworkTopology.InnerNode#getLeaf will never
return the last node on the rack if it is called with an excludedNode (for example the first
node on the rack). 
> Consequently I suspect that NetworkTopology.chooseRandom() will never returns the last
node on the remote rack for the second replica in DFS. 
> I have some test code that demonstrates this problem at the getLeaf level, although it
is necessary to change the visibility of the NetworkTopology.InnerNode, NetworkTopology.InnerNode#getLeaf
and NetworkTopology.getNode from private to package default to run the test. 
> TODO: Demonstrate problem at NetworkTopology.chooseRandom level, then submit candidate
fix. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message