hadoop-common-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Raghu Angadi (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HADOOP-2063) Command to pull corrupted files
Date Wed, 20 Feb 2008 22:25:43 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-2063?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12570857#action_12570857

Raghu Angadi commented on HADOOP-2063:

Initial Comments:

# why isn't "-f" valid if output is stdout?
# I would rename {{doChecksum}} to something like {{verifyChecksum}}
# The current implementation creates a new static FileSystem implementation inside DFS, and
thus we need a new static {{getSrcFileSystem()}}, which checks type at runtime. 
#- Since this could apply for any filesystem, how about making this a property of FileSystem?
So {{FsShell.get()}} would just set srcFS.setVerifyChecksum(false) in case of "-f" option?
# Not sure why we need small code reorg around {{decimalFormat}}? 
# "-f" for option ok? Ignoring checksum is used rare enough that it could be just named "-ignoreCrc"
or "-ignoreCrcErrors". But this is subjective.

> Command to pull corrupted files
> -------------------------------
>                 Key: HADOOP-2063
>                 URL: https://issues.apache.org/jira/browse/HADOOP-2063
>             Project: Hadoop Core
>          Issue Type: New Feature
>          Components: fs
>    Affects Versions: 0.14.1
>            Reporter: Koji Noguchi
>            Assignee: Tsz Wo (Nicholas), SZE
>            Priority: Blocker
>             Fix For: 0.17.0
>         Attachments: 2063_20080219.patch, 2063_20080220.patch
> Before 0.14, dfs -get didn't perform checksum checking.   
> Users were able to download the corrupted files to see if they want to delete them.
> After 0.14, dfs -get also does the checksumming. 
> Requesting a command for no-checksum-get command.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message