hadoop-common-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chris Douglas (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HADOOP-2895) String for configuring profiling should be customizable
Date Thu, 28 Feb 2008 21:35:51 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-2895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12573464#action_12573464
] 

Chris Douglas commented on HADOOP-2895:
---------------------------------------

The patch looks good. A minor nit: reordering/sorting the import stmts to match your preferences-
and formatting changes in general- adds unnecessary noise and is best avoided unless the changes
to the affected classes are dramatic. Would you mind regenerating your patch without those
modifications? Otherwise, +1

> String for configuring profiling should be customizable
> -------------------------------------------------------
>
>                 Key: HADOOP-2895
>                 URL: https://issues.apache.org/jira/browse/HADOOP-2895
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: mapred
>    Affects Versions: 0.16.0
>            Reporter: Martin Traverso
>            Assignee: Martin Traverso
>         Attachments: HADOOP-2895.patch
>
>
> The choice of options that Hadoop uses may not be appropriate for all cases, so it would
make sense to make this string configurable.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message