hadoop-common-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Raghu Angadi (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HADOOP-2683) Provide a way to specifiy login out side an RPC
Date Mon, 11 Feb 2008 16:42:09 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-2683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12567697#action_12567697
] 

Raghu Angadi commented on HADOOP-2683:
--------------------------------------

A few comments:

# Isn't this a security hole to get super user privileges? All client needs to do is to send
NULL for ticket, right? I think Server.getUserInfo() should only return ticket associated
with the RPC. 
# Minor: Could you remove debug in setCurrentUGI()? It is run for evey RPC.
# unrelated warning fixes in Server.java. It will conflict with HADOOP-2789.

> Provide a way to specifiy login out side an RPC
> -----------------------------------------------
>
>                 Key: HADOOP-2683
>                 URL: https://issues.apache.org/jira/browse/HADOOP-2683
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: dfs
>    Affects Versions: 0.16.0
>            Reporter: Raghu Angadi
>            Assignee: Tsz Wo (Nicholas), SZE
>            Priority: Blocker
>             Fix For: 0.16.1
>
>         Attachments: 2683_20080211.patch
>
>
> Requirements AFIK :
> It is required in some special cases (benchmarks etc) to invoke NameNode functionality
without an RPC. For this users should be able to set user information that is otherwise available
only an RPC.
> Patch for HADOOP-1298 includes a change to Server.java so that {{Server.getUserInfo()}}
does not need to in an RPC. This probably will be replaced by patch here. 
> Please include any other Jira's that depend on this.
> Proposed fix:
> - UserGroupInformation becomes an abstract class
> - public static UserGroupInformation.getUserInfo() is added. which usually just returns
Server.getUserInfo();
> - public static UserGroupInformation.setUserInfo(UserGroupInformation) sets  a thread
local that will returned if Server.getUserInfo() returns null. 
> - all invocations of Server.getUserInfo() will be replaced by UserGroupInformation.getUserInfo().

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message