hadoop-common-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mahadev konar (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HADOOP-2891) The dfsclient on exit deletes files that are open and not closed.
Date Tue, 26 Feb 2008 22:28:51 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-2891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12572698#action_12572698
] 

Mahadev konar commented on HADOOP-2891:
---------------------------------------

patch looks good.. 

1)
for the test case 

could you just have 


assertTrue(file1 + " does not exist.", 
+                 fs.exists(file1) ) 

rather than

assertTrue(file1 + " does not exist.", 
+                 fs.exists(file1) == true);
+


2) also it would be a good thing to have the check 

if (out !=null) {
 out.close()
}



> The dfsclient on exit deletes files that are open and not closed.
> -----------------------------------------------------------------
>
>                 Key: HADOOP-2891
>                 URL: https://issues.apache.org/jira/browse/HADOOP-2891
>             Project: Hadoop Core
>          Issue Type: Bug
>            Reporter: Mahadev konar
>            Assignee: dhruba borthakur
>             Fix For: 0.17.0
>
>         Attachments: abandonFile.patch
>
>
> the dfsclient has a shutdown hook that deletes files that have been left open but not
closed. We should not be cleaning up files that have been open and not closed. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message