Mailing-List: contact core-dev-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: core-dev@hadoop.apache.org
Message-ID: <3900291.1201798268328.JavaMail.jira@brutus>
Date: Thu, 31 Jan 2008 08:51:08 -0800 (PST)
From: "Clint Morgan (JIRA)" <jira@apache.org>
To: core-dev@hadoop.apache.org
Subject: [jira] Updated: (HADOOP-2718) Copy Constructor
 HBaseConfiguration(Configuration) will override hbase configurations if
 argumant is not an instance of HBaseConfiguration.
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


     [ https://issues.apache.org/jira/browse/HADOOP-2718?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Clint Morgan updated HADOOP-2718:
---------------------------------

    Attachment: conf.patch

Okay, I see the problem here:

In this particular case, the parameter is a JobConf, and so will usually need the hbase resources added.

My problem is I had hbase resources in the JobConf which I did not want them overriden by hbase*.xml

Dave's problem is that he has a normal JobConf, so he needs all the hbase resources.

So we can both be happy if we get the hbase resources in there, then set all of the parametric config's values.

So change the super() call to a this() call to get the hbase resources in first.

I'd like this for 0.16.


> Copy Constructor HBaseConfiguration(Configuration) will override hbase configurations if argumant is not an instance of HBaseConfiguration.
> -------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: HADOOP-2718
>                 URL: https://issues.apache.org/jira/browse/HADOOP-2718
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: contrib/hbase
>            Reporter: Clint Morgan
>            Priority: Blocker
>             Fix For: 0.16.0
>
>         Attachments: conf.patch, conf.patch
>
>
> Copy Constructor HBaseConfiguration(Configuration) will override hbase
> settings from the argument if the arg is not an instance of HBaseConfiguration.
> This was happening to me when I was passing around hbase settings as
> part of a Table Map/Reduce job configuration.
> Observer the following unexpected behavior:
> JobConf jobConf = new JobConf("job.xml");
> HBaseConfiguration hbaseConf = new HBaseConfiguration(jobConf);
> String result1 = jobConf.get("hbase.master");  // Value from job.xml loaded by tasktracker
> String result2 = hbaseConf.get("hbase.master"); // Value from hbase-site.xml
> Assert.assertEquals(result1, result2); // Fail 
> In particular, this copy constructor is called in hbase.mapred.TableInputFormat.configure(JobConf).
> I have a hbase.master defined in my JobConf that gets overridden in the HbaseConfiguration by hbase-site.xml.
> Should the Constructor instead add new hbase-specific values if they are not already defined in the Configuration parameter?

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.