Return-Path: Delivered-To: apmail-hadoop-core-dev-archive@www.apache.org Received: (qmail 79303 invoked from network); 25 Jan 2008 13:57:04 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 25 Jan 2008 13:57:04 -0000 Received: (qmail 78225 invoked by uid 500); 25 Jan 2008 13:56:49 -0000 Delivered-To: apmail-hadoop-core-dev-archive@hadoop.apache.org Received: (qmail 78195 invoked by uid 500); 25 Jan 2008 13:56:49 -0000 Mailing-List: contact core-dev-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: core-dev@hadoop.apache.org Delivered-To: mailing list core-dev@hadoop.apache.org Received: (qmail 78159 invoked by uid 500); 25 Jan 2008 13:56:49 -0000 Delivered-To: apmail-lucene-hadoop-dev@lucene.apache.org Received: (qmail 78134 invoked by uid 99); 25 Jan 2008 13:56:49 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 25 Jan 2008 05:56:49 -0800 X-ASF-Spam-Status: No, hits=-100.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.4] (HELO brutus.apache.org) (140.211.11.4) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 25 Jan 2008 13:56:43 +0000 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id 55E0771425F for ; Fri, 25 Jan 2008 05:56:35 -0800 (PST) Message-ID: <31048746.1201269395348.JavaMail.jira@brutus> Date: Fri, 25 Jan 2008 05:56:35 -0800 (PST) From: "Hudson (JIRA)" To: hadoop-dev@lucene.apache.org Subject: [jira] Commented: (HADOOP-1195) NullPointerException in FSNamesystem due to getDatanode() return value is not checked In-Reply-To: <16927233.1175561072231.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/HADOOP-1195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12562501#action_12562501 ] Hudson commented on HADOOP-1195: -------------------------------- Integrated in Hadoop-trunk #379 (See [http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/379/]) > NullPointerException in FSNamesystem due to getDatanode() return value is not checked > ------------------------------------------------------------------------------------- > > Key: HADOOP-1195 > URL: https://issues.apache.org/jira/browse/HADOOP-1195 > Project: Hadoop Core > Issue Type: Bug > Components: dfs > Reporter: Konstantin Shvachko > Assignee: dhruba borthakur > Fix For: 0.16.0 > > Attachments: datanodeNullPointer.patch, datanodeNullPointer.patch, datanodeNullPointer.patch > > > FSNamesystem.getDatanode( nodeID ) returns null if the node is not found. > There are several places where we do not check wether the returned node is null, e.g. > FSNamesystem.processReport() > FSNamesystem.setDatanodeDead() > FSNamesystem.invalidateBlock() > FSNamesystem.verifyNodeRegistration() > I'm getting the following NPE: > 07/04/02 17:31:50 WARN dfs.DataNode: org.apache.hadoop.ipc.RemoteException: java.io.IOException: java.lang.NullPointerException > at org.apache.hadoop.dfs.FSNamesystem.shouldNodeShutdown(FSNamesystem.java:3306) > at org.apache.hadoop.dfs.FSNamesystem.processReport(FSNamesystem.java:2012) > at org.apache.hadoop.dfs.NameNode.blockReport(NameNode.java:654) > at sun.reflect.GeneratedMethodAccessor7.invoke(Unknown Source) > at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25) > at java.lang.reflect.Method.invoke(Method.java:585) > at org.apache.hadoop.ipc.RPC$Server.call(RPC.java:341) > at org.apache.hadoop.ipc.Server$Handler.run(Server.java:580) > at org.apache.hadoop.ipc.Client.call(Client.java:473) > at org.apache.hadoop.ipc.RPC$Invoker.invoke(RPC.java:164) > at org.apache.hadoop.dfs.$Proxy1.blockReport(Unknown Source) > at org.apache.hadoop.dfs.DataNode.offerService(DataNode.java:460) > at org.apache.hadoop.dfs.DataNode.run(DataNode.java:1095) > at org.apache.hadoop.dfs.MiniDFSCluster$DataNodeRunner.run(MiniDFSCluster.java:160) > at java.lang.Thread.run(Thread.java:595) -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.