Return-Path: Delivered-To: apmail-lucene-hadoop-dev-archive@locus.apache.org Received: (qmail 56963 invoked from network); 5 Jan 2008 07:32:56 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 5 Jan 2008 07:32:56 -0000 Received: (qmail 12069 invoked by uid 500); 5 Jan 2008 07:32:45 -0000 Delivered-To: apmail-lucene-hadoop-dev-archive@lucene.apache.org Received: (qmail 12024 invoked by uid 500); 5 Jan 2008 07:32:44 -0000 Mailing-List: contact hadoop-dev-help@lucene.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: hadoop-dev@lucene.apache.org Delivered-To: mailing list hadoop-dev@lucene.apache.org Received: (qmail 12015 invoked by uid 99); 5 Jan 2008 07:32:44 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 04 Jan 2008 23:32:44 -0800 X-ASF-Spam-Status: No, hits=-100.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.4] (HELO brutus.apache.org) (140.211.11.4) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 05 Jan 2008 07:32:29 +0000 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id 12BA07141F1 for ; Fri, 4 Jan 2008 23:32:34 -0800 (PST) Message-ID: <19531319.1199518354073.JavaMail.jira@brutus> Date: Fri, 4 Jan 2008 23:32:34 -0800 (PST) From: "Hadoop QA (JIRA)" To: hadoop-dev@lucene.apache.org Subject: [jira] Commented: (HADOOP-2532) Add to MapFile a getClosest that returns key that comes just-before if key not present (Currently does just-after only). In-Reply-To: <2347130.1199498014142.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/HADOOP-2532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12556185#action_12556185 ] Hadoop QA commented on HADOOP-2532: ----------------------------------- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12372547/getclosestbefore-v2.patch against trunk revision . @author +1. The patch does not contain any @author tags. javadoc -1. The javadoc tool appears to have generated messages. javac +1. The applied patch does not generate any new compiler warnings. findbugs +1. The patch does not introduce any new Findbugs warnings. core tests +1. The patch passed core unit tests. contrib tests -1. The patch failed contrib unit tests. Test results: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/1473/testReport/ Findbugs warnings: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/1473/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/1473/artifact/trunk/build/test/checkstyle-errors.html Console output: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/1473/console This message is automatically generated. > Add to MapFile a getClosest that returns key that comes just-before if key not present (Currently does just-after only). > ------------------------------------------------------------------------------------------------------------------------ > > Key: HADOOP-2532 > URL: https://issues.apache.org/jira/browse/HADOOP-2532 > Project: Hadoop > Issue Type: New Feature > Reporter: stack > Priority: Minor > Fix For: 0.16.0 > > Attachments: getclosestbefore-v2.patch, getclosestbefore.patch > > > The list of regions that make up a table in hbase are effectively kept in a mapfile. Regions are identified by the first row contained by that region. To find the region that contains a particular row, we need to be able to search the mapfile of regions to find the closest matching row that falls just-before the searched-for key rather than the just-after that is current mapfile getClosest behavior. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.