hadoop-common-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jim Kellerman (JIRA)" <j...@apache.org>
Subject [jira] Issue Comment Edited: (HADOOP-2525) Same 2 lines repeated 11 million times in HMaster log upon HMaster shutdown
Date Thu, 17 Jan 2008 23:15:34 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-2525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12560143#action_12560143
] 

jimk edited comment on HADOOP-2525 at 1/17/08 3:14 PM:
----------------------------------------------------------------

> Otherwise patch looks good. How you think it fixes the issue?

The crux of the patch is the following change:

{code}
-      for (RegionServerOperation op = null; !closed.get(); ) {
+      while (!closed.get()) {
+        RegionServerOperation op = null;
{code}

the old code only declared and nulled out 'op' for the first iteration. If op was set non-null
and went back to top of loop, it would fall through and just re-execute op again, rather than
polling the queues and waiting.


      was (Author: jimk):
    > Otherwise patch looks good. How you think it fixes the issue?

The crux of the patch is the following change:

-      for (RegionServerOperation op = null; !closed.get(); ) {
+      while (!closed.get()) {
+        RegionServerOperation op = null;

the old code only declared and nulled out 'op' for the first iteration. If op was set non-null
and went back to top of loop, it would fall through and just re-execute op again, rather than
polling the queues and waiting.

  
> Same 2 lines repeated 11 million times in HMaster log upon HMaster shutdown
> ---------------------------------------------------------------------------
>
>                 Key: HADOOP-2525
>                 URL: https://issues.apache.org/jira/browse/HADOOP-2525
>             Project: Hadoop
>          Issue Type: Bug
>          Components: contrib/hbase
>    Affects Versions: 0.15.0
>         Environment: CentOS 5
>            Reporter: Chris Kline
>            Assignee: Jim Kellerman
>            Priority: Minor
>             Fix For: 0.16.0
>
>         Attachments: patch.txt
>
>
> Background: We ran out of disk space on HMaster before this issue occurred.  The sequence
of events were:
> 1.  Ran out of disk space
> 2.  Freed up 10 GB of disk space
> 3.  Shut down HBase
> We had the following 2 lines repeated over 11 million times in the span of 10 minutes:
> 2007-12-24 08:50:41,851 INFO org.apache.hadoop.hbase.HMaster: process shutdown of server
10.100.11.64:60020: logSplit: true, rootChecked: false, rootRescanned: false, numberOfMetaRegions:
1, onlineMetaRegions.size(): 0
> 2007-12-24 08:50:43,980 DEBUG org.apache.hadoop.hbase.HMaster: Main processing loop:
ProcessServerShutdown of 10.100.11.64:60020

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message